Skip to content

Unpin funcy #2470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
weiji14 merged 2 commits into from
Apr 2, 2023
Merged

Unpin funcy #2470

weiji14 merged 2 commits into from
Apr 2, 2023

Conversation

@seisman
Copy link
Member

@seisman seisman commented Mar 30, 2023

Description of proposed changes

This PR reverts the changes in #2468.

Fixes #

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added this to the 0.10.0 milestone Mar 30, 2023
@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Mar 30, 2023
@weiji14
Copy link
Member

weiji14 commented Mar 31, 2023

So treeverse/dvc#9279 has been merged with the fix for funcy, and dvc has released 2.25.0, see also corresponding conda-forge release conda-forge/dvc-feedstock#337. We can test and merge this after PyGMT v0.9.0.

@seisman seisman marked this pull request as ready for review March 31, 2023 23:59
@seisman seisman changed the title WIP: Unpin funcy Unpin funcy Mar 31, 2023
@seisman seisman added the needs review This PR has higher priority and needs review. label Apr 1, 2023
@weiji14 weiji14 merged commit aaa0ca0 into main Apr 2, 2023
@weiji14 weiji14 deleted the unpin-funcy branch April 2, 2023 20:15
@seisman seisman removed the needs review This PR has higher priority and needs review. label Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weiji14 weiji14 weiji14 approved these changes

Assignees

No one assigned

Labels

maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog

Projects

None yet

Milestone

0.10.0

Development

Successfully merging this pull request may close these issues.

3 participants

@seisman @weiji14